Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Selenium] Update DevWorkspaceHappyPath test sample name #19384

Merged
merged 1 commit into from
Mar 24, 2021
Merged

[Selenium] Update DevWorkspaceHappyPath test sample name #19384

merged 1 commit into from
Mar 24, 2021

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

As DevWorkspaceHappyPath test uses devfile from https://github.com/l0rd/spring-petclinic/tree/devfile2 repo we need to change sample project name to spring-petclinic.

What issues does this PR fix or reference?

#18888

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. area/qe labels Mar 24, 2021
@SkorikSergey SkorikSergey self-assigned this Mar 24, 2021
@che-bot
Copy link
Contributor

che-bot commented Mar 24, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@SkorikSergey SkorikSergey marked this pull request as ready for review March 24, 2021 14:53
@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Mar 24, 2021
dmytro-ndp
dmytro-ndp approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@SkorikSergey SkorikSergey merged commit 90d7214 into master Mar 24, 2021
@SkorikSergey SkorikSergey deleted the updateDevworkspaceHappyPathTest branch March 24, 2021 15:49
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 24, 2021
@che-bot che-bot added this to the 7.28 milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees

@SkorikSergey SkorikSergey

Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.28
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SkorikSergey @che-bot @dmytro-ndp @Ohrimenko1988